jro_apps/redmine Files · app/controllers/enumerations_controller.rb

scm: git: performance improvements in fetching revisions (#8857, #9472)...

scm: git: performance improvements in fetching revisions (#8857, #9472) Parse a revision for a given branch, just if we haven't parsed it for any branches before. Moved the db check to for existing revisions into a grouped search. Search for many revisions at once: this reduces db load. Revisions are grouped into sets of 100. This is to improve memory consumption. There will be just one query instead of each 100. The above two methods significantly increase parsing speed. Test case was a git repo with 6000+ commits on a master branch, and several other branches originating for master. Speed improved from 1.4h to 18min. Contributed by Gergely Fábián. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9144 e93f8b46-1217-0410-a6f0-8f06a7374b81

Jean-Philippe Lang - - Load All Authors

File last commit:

r8941:b3866b05c14b


                r9024:999a4ba30d7b

Download file

             enumerations_controller.rb
        
                    85 lines
            
             | 2.4 KiB
            
                | text/x-ruby
            
             |
                RubyLexer
            
             / app / controllers / enumerations_controller.rb
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Toshi MARUYAMA
    
remove trailing white-spaces from app/controllers/enumerations_controller.rb....

              r6785
            
      # Redmine - project management software

      # Copyright (C) 2006-2011  Jean-Philippe Lang

        Jean-Philippe Lang
    
added svn:eol-style native property on /app files...

              r330
            
      #

      # This program is free software; you can redistribute it and/or

      # modify it under the terms of the GNU General Public License

      # as published by the Free Software Foundation; either version 2

      # of the License, or (at your option) any later version.

        Toshi MARUYAMA
    
remove trailing white-spaces from app/controllers/enumerations_controller.rb....

              r6785
            
      #

        Jean-Philippe Lang
    
added svn:eol-style native property on /app files...

              r330
            
      # This program is distributed in the hope that it will be useful,

      # but WITHOUT ANY WARRANTY; without even the implied warranty of

      # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

      # GNU General Public License for more details.

        Toshi MARUYAMA
    
remove trailing white-spaces from app/controllers/enumerations_controller.rb....

              r6785
            
      #

        Jean-Philippe Lang
    
added svn:eol-style native property on /app files...

              r330
            
      # You should have received a copy of the GNU General Public License

      # along with this program; if not, write to the Free Software

      # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.

      class EnumerationsController < ApplicationController

        Jean-Philippe Lang
    
Adds an admin layout that displays the admin menu in the sidebar....

              r3062
            
        layout 'admin'

        Toshi MARUYAMA
    
remove trailing white-spaces from app/controllers/enumerations_controller.rb....

              r6785
            
        Jean-Philippe Lang
    
added svn:eol-style native property on /app files...

              r330
            
        before_filter :require_admin

        Jean-Philippe Lang
    
Resourcified enumerations....

              r8069
            
        before_filter :build_new_enumeration, :only => [:new, :create]

        before_filter :find_enumeration, :only => [:edit, :update, :destroy]

        Eric Davis
    
Enumerations can now have custom fields defined on them. #4077...

              r2831
            
        helper :custom_fields

        Toshi MARUYAMA
    
remove trailing white-spaces from app/controllers/enumerations_controller.rb....

              r6785
            
        Jean-Philippe Lang
    
Initial commit...

              r2
            
        def index

        end

        def new

        end

        def create

        Jean-Philippe Lang
    
Resourcified enumerations....

              r8069
            
          if request.post? && @enumeration.save

        Jean-Philippe Lang
    
Localization plugin removed (replaced with GLoc)...

              r12
            
            flash[:notice] = l(:notice_successful_create)

        Jean-Philippe Lang
    
Removed EnumerationsController#list action....

              r7853
            
            redirect_to :action => 'index', :type => @enumeration.type

        Jean-Philippe Lang
    
Initial commit...

              r2
            
          else

            render :action => 'new'

          end

        end

        def edit

        end

        def update

        Jean-Philippe Lang
    
Resourcified enumerations....

              r8069
            
          if request.put? && @enumeration.update_attributes(params[:enumeration])

        Jean-Philippe Lang
    
Localization plugin removed (replaced with GLoc)...

              r12
            
            flash[:notice] = l(:notice_successful_update)

        Jean-Philippe Lang
    
Removed EnumerationsController#list action....

              r7853
            
            redirect_to :action => 'index', :type => @enumeration.type

        Jean-Philippe Lang
    
Initial commit...

              r2
            
          else

            render :action => 'edit'

          end

        end

        Toshi MARUYAMA
    
remove trailing white-spaces from app/controllers/enumerations_controller.rb....

              r6785
            
        Jean-Philippe Lang
    
Initial commit...

              r2
            
        def destroy

        Jean-Philippe Lang
    
Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value (#1467)....

              r1544
            
          if !@enumeration.in_use?

            # No associated objects

            @enumeration.destroy

            redirect_to :action => 'index'

        Toshi MARUYAMA
    
Fix potential Execution After Redirect bugs....

              r5491
            
            return

        Jean-Philippe Lang
    
Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value (#1467)....

              r1544
            
          elsif params[:reassign_to_id]

        Jean-Philippe Lang
    
Fixed: error while deleting an in-use enumeration (#4970)....

              r3410
            
            if reassign_to = @enumeration.class.find_by_id(params[:reassign_to_id])

        Jean-Philippe Lang
    
Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value (#1467)....

              r1544
            
              @enumeration.destroy(reassign_to)

              redirect_to :action => 'index'

        Toshi MARUYAMA
    
Fix potential Execution After Redirect bugs....

              r5491
            
              return

        Jean-Philippe Lang
    
Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value (#1467)....

              r1544
            
            end

          end

        Jean-Philippe Lang
    
Resourcified enumerations....

              r8069
            
          @enumerations = @enumeration.class.all - [@enumeration]

        end

        private

        def build_new_enumeration

          class_name = params[:enumeration] && params[:enumeration][:type] || params[:type]

          @enumeration = Enumeration.new_subclass_instance(class_name, params[:enumeration])

          if @enumeration.nil?

            render_404

          end

        end

        def find_enumeration

          @enumeration = Enumeration.find(params[:id])

        rescue ActiveRecord::RecordNotFound

          render_404

        Jean-Philippe Lang
    
Initial commit...

              r2
            
        end

      end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Toshi MARUYAMA remove trailing white-spaces from app/controllers/enumerations_controller.rb....	r6785	# Redmine - project management software
		# Copyright (C) 2006-2011 Jean-Philippe Lang
Jean-Philippe Lang added svn:eol-style native property on /app files...	r330	#
		# This program is free software; you can redistribute it and/or
		# modify it under the terms of the GNU General Public License
		# as published by the Free Software Foundation; either version 2
		# of the License, or (at your option) any later version.
Toshi MARUYAMA remove trailing white-spaces from app/controllers/enumerations_controller.rb....	r6785	#
Jean-Philippe Lang added svn:eol-style native property on /app files...	r330	# This program is distributed in the hope that it will be useful,
		# but WITHOUT ANY WARRANTY; without even the implied warranty of
		# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
		# GNU General Public License for more details.
Toshi MARUYAMA remove trailing white-spaces from app/controllers/enumerations_controller.rb....	r6785	#
Jean-Philippe Lang added svn:eol-style native property on /app files...	r330	# You should have received a copy of the GNU General Public License
		# along with this program; if not, write to the Free Software
		# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

		class EnumerationsController < ApplicationController
Jean-Philippe Lang Adds an admin layout that displays the admin menu in the sidebar....	r3062	layout 'admin'
Toshi MARUYAMA remove trailing white-spaces from app/controllers/enumerations_controller.rb....	r6785
Jean-Philippe Lang added svn:eol-style native property on /app files...	r330	before_filter :require_admin
Jean-Philippe Lang Resourcified enumerations....	r8069	before_filter :build_new_enumeration, :only => [:new, :create]
		before_filter :find_enumeration, :only => [:edit, :update, :destroy]
Eric Davis Enumerations can now have custom fields defined on them. #4077...	r2831
		helper :custom_fields
Toshi MARUYAMA remove trailing white-spaces from app/controllers/enumerations_controller.rb....	r6785
Jean-Philippe Lang Initial commit...	r2	def index
		end

		def new
		end

		def create
Jean-Philippe Lang Resourcified enumerations....	r8069	if request.post? && @enumeration.save
Jean-Philippe Lang Localization plugin removed (replaced with GLoc)...	r12	flash[:notice] = l(:notice_successful_create)
Jean-Philippe Lang Removed EnumerationsController#list action....	r7853	redirect_to :action => 'index', :type => @enumeration.type
Jean-Philippe Lang Initial commit...	r2	else
		render :action => 'new'
		end
		end

		def edit
		end

		def update
Jean-Philippe Lang Resourcified enumerations....	r8069	if request.put? && @enumeration.update_attributes(params[:enumeration])
Jean-Philippe Lang Localization plugin removed (replaced with GLoc)...	r12	flash[:notice] = l(:notice_successful_update)
Jean-Philippe Lang Removed EnumerationsController#list action....	r7853	redirect_to :action => 'index', :type => @enumeration.type
Jean-Philippe Lang Initial commit...	r2	else
		render :action => 'edit'
		end
		end
Toshi MARUYAMA remove trailing white-spaces from app/controllers/enumerations_controller.rb....	r6785
Jean-Philippe Lang Initial commit...	r2	def destroy
Jean-Philippe Lang Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value (#1467)....	r1544	if !@enumeration.in_use?
		# No associated objects
		@enumeration.destroy
		redirect_to :action => 'index'
Toshi MARUYAMA Fix potential Execution After Redirect bugs....	r5491	return
Jean-Philippe Lang Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value (#1467)....	r1544	elsif params[:reassign_to_id]
Jean-Philippe Lang Fixed: error while deleting an in-use enumeration (#4970)....	r3410	if reassign_to = @enumeration.class.find_by_id(params[:reassign_to_id])
Jean-Philippe Lang Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value (#1467)....	r1544	@enumeration.destroy(reassign_to)
		redirect_to :action => 'index'
Toshi MARUYAMA Fix potential Execution After Redirect bugs....	r5491	return
Jean-Philippe Lang Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value (#1467)....	r1544	end
		end
Jean-Philippe Lang Resourcified enumerations....	r8069	@enumerations = @enumeration.class.all - [@enumeration]
		end

		private

		def build_new_enumeration
		class_name = params[:enumeration] && params[:enumeration][:type] \|\| params[:type]
		@enumeration = Enumeration.new_subclass_instance(class_name, params[:enumeration])
		if @enumeration.nil?
		render_404
		end
		end

		def find_enumeration
		@enumeration = Enumeration.find(params[:id])
		rescue ActiveRecord::RecordNotFound
		render_404
Jean-Philippe Lang Initial commit...	r2	end
		end