issues_controller.rb
330 lines
| 12.9 KiB
| text/x-ruby
|
RubyLexer
|
r1796 | # Redmine - project management software | ||
# Copyright (C) 2006-2008 Jean-Philippe Lang | ||||
|
r330 | # | ||
# This program is free software; you can redistribute it and/or | ||||
# modify it under the terms of the GNU General Public License | ||||
# as published by the Free Software Foundation; either version 2 | ||||
# of the License, or (at your option) any later version. | ||||
# | ||||
# This program is distributed in the hope that it will be useful, | ||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||||
# GNU General Public License for more details. | ||||
# | ||||
# You should have received a copy of the GNU General Public License | ||||
# along with this program; if not, write to the Free Software | ||||
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||||
class IssuesController < ApplicationController | ||||
|
r3590 | menu_item :new_issue, :only => [:new, :create] | ||
|
r2829 | default_search_scope :issues | ||
|
r1067 | |||
|
r3827 | before_filter :find_issue, :only => [:show, :edit, :update] | ||
|
r3923 | before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy] | ||
|
r4114 | before_filter :check_project_uniqueness, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy] | ||
|
r3897 | before_filter :find_project, :only => [:new, :create] | ||
|
r3920 | before_filter :authorize, :except => [:index] | ||
before_filter :find_optional_project, :only => [:index] | ||||
|
r3576 | before_filter :check_for_default_issue_status, :only => [:new, :create] | ||
|
r3575 | before_filter :build_new_issue_from_params, :only => [:new, :create] | ||
|
r3920 | accept_key_auth :index, :show | ||
|
r330 | |||
|
r2990 | rescue_from Query::StatementInvalid, :with => :query_statement_invalid | ||
|
r1091 | helper :journals | ||
|
r559 | helper :projects | ||
include ProjectsHelper | ||||
|
r330 | helper :custom_fields | ||
include CustomFieldsHelper | ||||
|
r503 | helper :issue_relations | ||
include IssueRelationsHelper | ||||
|
r527 | helper :watchers | ||
include WatchersHelper | ||||
|
r538 | helper :attachments | ||
|
r673 | include AttachmentsHelper | ||
helper :queries | ||||
|
r3219 | include QueriesHelper | ||
|
r673 | helper :sort | ||
include SortHelper | ||||
|
r874 | include IssuesHelper | ||
|
r1588 | helper :timelog | ||
|
r3958 | helper :gantt | ||
|
r2224 | include Redmine::Export::PDF | ||
|
r21 | |||
|
r3196 | verify :method => [:post, :delete], | ||
|
r2866 | :only => :destroy, | ||
:render => { :nothing => true, :status => :method_not_allowed } | ||||
|
r3406 | |||
|
r3574 | verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed } | ||
|
r3923 | verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed } | ||
|
r3406 | verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed } | ||
|
r673 | def index | ||
retrieve_query | ||||
|
r2504 | sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria) | ||
|
r3490 | sort_update(@query.sortable_columns) | ||
|
r2169 | |||
|
r673 | if @query.valid? | ||
|
r3254 | limit = case params[:format] | ||
when 'csv', 'pdf' | ||||
Setting.issues_export_limit.to_i | ||||
when 'atom' | ||||
Setting.feeds_limit.to_i | ||||
else | ||||
per_page_option | ||||
|
r1171 | end | ||
|
r2989 | |||
@issue_count = @query.issue_count | ||||
|
r874 | @issue_pages = Paginator.new self, @issue_count, limit, params['page'] | ||
|
r2989 | @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version], | ||
:order => sort_clause, | ||||
:offset => @issue_pages.current.offset, | ||||
:limit => limit) | ||||
@issue_count_by_group = @query.issue_count_by_group | ||||
|
r874 | respond_to do |format| | ||
|
r2989 | format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? } | ||
|
r3196 | format.xml { render :layout => false } | ||
|
r3652 | format.json { render :text => @issues.to_json, :layout => false } | ||
|
r1627 | format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") } | ||
|
r2893 | format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') } | ||
|
r2604 | format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') } | ||
|
r874 | end | ||
else | ||||
# Send html if the query is not valid | ||||
render(:template => 'issues/index.rhtml', :layout => !request.xhr?) | ||||
|
r673 | end | ||
|
r1296 | rescue ActiveRecord::RecordNotFound | ||
render_404 | ||||
|
r874 | end | ||
|
r21 | def show | ||
|
r627 | @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC") | ||
|
r1183 | @journals.each_with_index {|j,i| j.indice = i+1} | ||
@journals.reverse! if User.current.wants_comments_in_reverse_order? | ||||
|
r3243 | @changesets = @issue.changesets.visible.all | ||
|
r2455 | @changesets.reverse! if User.current.wants_comments_in_reverse_order? | ||
|
r1115 | @allowed_statuses = @issue.new_statuses_allowed_to(User.current) | ||
@edit_allowed = User.current.allowed_to?(:edit_issues, @project) | ||||
|
r2677 | @priorities = IssuePriority.all | ||
|
r1447 | @time_entry = TimeEntry.new | ||
|
r874 | respond_to do |format| | ||
format.html { render :template => 'issues/show.rhtml' } | ||||
|
r3196 | format.xml { render :layout => false } | ||
|
r3652 | format.json { render :text => @issue.to_json, :layout => false } | ||
|
r3920 | format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' } | ||
|
r2224 | format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") } | ||
|
r799 | end | ||
|
r21 | end | ||
|
r2 | |||
|
r1066 | # Add a new issue | ||
# The new issue will be created from an existing one if copy_from parameter is given | ||||
def new | ||||
|
r3897 | respond_to do |format| | ||
format.html { render :action => 'new', :layout => !request.xhr? } | ||||
format.js { render :partial => 'attributes' } | ||||
end | ||||
|
r3574 | end | ||
def create | ||||
call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue }) | ||||
if @issue.save | ||||
attachments = Attachment.attach_files(@issue, params[:attachments]) | ||||
render_attachment_warning_if_needed(@issue) | ||||
flash[:notice] = l(:notice_successful_create) | ||||
call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue}) | ||||
respond_to do |format| | ||||
format.html { | ||||
|
r3969 | redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } : | ||
|
r3574 | { :action => 'show', :id => @issue }) | ||
} | ||||
format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) } | ||||
|
r3652 | format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false } | ||
|
r3574 | end | ||
return | ||||
else | ||||
respond_to do |format| | ||||
format.html { render :action => 'new' } | ||||
format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return } | ||||
|
r3652 | format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false } | ||
|
r3574 | end | ||
end | ||||
|
r1066 | end | ||
|
r1115 | # Attributes that can be updated on workflow transition (without :edit permission) | ||
# TODO: make it configurable (at least per role) | ||||
UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION) | ||||
|
r330 | def edit | ||
|
r3373 | update_issue_from_params | ||
|
r1116 | |||
|
r3426 | @journal = @issue.current_journal | ||
|
r3372 | respond_to do |format| | ||
format.html { } | ||||
format.xml { } | ||||
end | ||||
end | ||||
def update | ||||
|
r3373 | update_issue_from_params | ||
|
r3372 | |||
|
r3431 | if @issue.save_issue_with_child_records(params, @time_entry) | ||
render_attachment_warning_if_needed(@issue) | ||||
|
r3432 | flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record? | ||
|
r3431 | |||
|
r3383 | respond_to do |format| | ||
format.html { redirect_back_or_default({:action => 'show', :id => @issue}) } | ||||
format.xml { head :ok } | ||||
|
r3652 | format.json { head :ok } | ||
|
r330 | end | ||
|
r3383 | else | ||
|
r3431 | render_attachment_warning_if_needed(@issue) | ||
|
r3432 | flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record? | ||
|
r3426 | @journal = @issue.current_journal | ||
|
r3431 | |||
|
r3196 | respond_to do |format| | ||
|
r3366 | format.html { render :action => 'edit' } | ||
|
r3196 | format.xml { render :xml => @issue.errors, :status => :unprocessable_entity } | ||
|
r3652 | format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false } | ||
|
r3196 | end | ||
|
r1030 | end | ||
|
r21 | end | ||
|
r1116 | # Bulk edit a set of issues | ||
def bulk_edit | ||||
|
r3459 | @issues.sort! | ||
|
r3008 | @available_statuses = Workflow.available_statuses(@project) | ||
|
r3164 | @custom_fields = @project.all_issue_custom_fields | ||
|
r1116 | end | ||
|
r3923 | |||
def bulk_update | ||||
@issues.sort! | ||||
|
r3926 | attributes = parse_params_for_bulk_issue_attributes(params) | ||
|
r3923 | |||
unsaved_issue_ids = [] | ||||
@issues.each do |issue| | ||||
issue.reload | ||||
journal = issue.init_journal(User.current, params[:notes]) | ||||
issue.safe_attributes = attributes | ||||
call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue }) | ||||
unless issue.save | ||||
# Keep unsaved issue ids to display them in flash error | ||||
unsaved_issue_ids << issue.id | ||||
end | ||||
end | ||||
set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids) | ||||
redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project}) | ||||
end | ||||
|
r1116 | |||
|
r21 | def destroy | ||
|
r1168 | @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f | ||
if @hours > 0 | ||||
case params[:todo] | ||||
when 'destroy' | ||||
# nothing to do | ||||
when 'nullify' | ||||
TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues]) | ||||
when 'reassign' | ||||
reassign_to = @project.issues.find_by_id(params[:reassign_to_id]) | ||||
if reassign_to.nil? | ||||
flash.now[:error] = l(:error_issue_not_found_in_project) | ||||
return | ||||
else | ||||
TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues]) | ||||
end | ||||
else | ||||
|
r3652 | unless params[:format] == 'xml' || params[:format] == 'json' | ||
|
r3196 | # display the destroy form if it's a user request | ||
return | ||||
end | ||||
|
r1168 | end | ||
end | ||||
|
r1116 | @issues.each(&:destroy) | ||
|
r3196 | respond_to do |format| | ||
format.html { redirect_to :action => 'index', :project_id => @project } | ||||
format.xml { head :ok } | ||||
|
r3652 | format.json { head :ok } | ||
|
r3196 | end | ||
|
r330 | end | ||
private | ||||
|
r1066 | def find_issue | ||
|
r330 | @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category]) | ||
@project = @issue.project | ||||
rescue ActiveRecord::RecordNotFound | ||||
render_404 | ||||
|
r673 | end | ||
|
r1066 | def find_project | ||
|
r3196 | project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id] | ||
@project = Project.find(project_id) | ||||
|
r1066 | rescue ActiveRecord::RecordNotFound | ||
render_404 | ||||
end | ||||
|
r3373 | # Used by #edit and #update to set some common instance variables | ||
# from the params | ||||
# TODO: Refactor, not everything in here is needed by #edit | ||||
def update_issue_from_params | ||||
@allowed_statuses = @issue.new_statuses_allowed_to(User.current) | ||||
@priorities = IssuePriority.all | ||||
@edit_allowed = User.current.allowed_to?(:edit_issues, @project) | ||||
@time_entry = TimeEntry.new | ||||
|
r3934 | @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil) | ||
|
r3426 | @issue.init_journal(User.current, @notes) | ||
|
r3373 | # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed | ||
if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue] | ||||
attrs = params[:issue].dup | ||||
attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed | ||||
attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s} | ||||
@issue.safe_attributes = attrs | ||||
end | ||||
end | ||||
|
r3446 | |||
|
r3575 | # TODO: Refactor, lots of extra code in here | ||
|
r4067 | # TODO: Changing tracker on an existing issue should not trigger this | ||
|
r3575 | def build_new_issue_from_params | ||
|
r3897 | if params[:id].blank? | ||
@issue = Issue.new | ||||
@issue.copy_from(params[:copy_from]) if params[:copy_from] | ||||
@issue.project = @project | ||||
else | ||||
@issue = @project.issues.visible.find(params[:id]) | ||||
end | ||||
|
r3575 | @issue.project = @project | ||
# Tracker must be set before custom field values | ||||
@issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first) | ||||
if @issue.tracker.nil? | ||||
render_error l(:error_no_tracker_in_project) | ||||
return false | ||||
end | ||||
if params[:issue].is_a?(Hash) | ||||
@issue.safe_attributes = params[:issue] | ||||
|
r4067 | if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record? | ||
@issue.watcher_user_ids = params[:issue]['watcher_user_ids'] | ||||
end | ||||
|
r3575 | end | ||
@issue.author = User.current | ||||
@issue.start_date ||= Date.today | ||||
@priorities = IssuePriority.all | ||||
@allowed_statuses = @issue.new_statuses_allowed_to(User.current, true) | ||||
end | ||||
|
r3576 | def check_for_default_issue_status | ||
if IssueStatus.default.nil? | ||||
render_error l(:error_no_default_issue_status) | ||||
return false | ||||
end | ||||
end | ||||
|
r3926 | |||
def parse_params_for_bulk_issue_attributes(params) | ||||
attributes = (params[:issue] || {}).reject {|k,v| v.blank?} | ||||
attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'} | ||||
attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values] | ||||
attributes | ||||
end | ||||
|
r2 | end | ||