##// END OF EJS Templates
jro_apps » redmine
RSS
Fixed that 200 API responses have a body containing one space (#11388)....
Fixed that 200 API responses have a body containing one space (#11388). git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9975 e93f8b46-1217-0410-a6f0-8f06a7374b81
Jean-Philippe Lang - - Load All Authors

File last commit:

r9792:18f693f9f7c1
r9792:18f693f9f7c1
Show More
memberships_test.rb
200 lines | 6.7 KiB | text/x-ruby | RubyLexer
/ test / integration / api_test / memberships_test.rb
History | Source | Raw |Copy content |Copy permalink
Jean-Philippe Lang
REST API for project memberships (#7420)....
 r8678 # Redmine - project management software
# Copyright (C) 2006-2012 Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../../../test_helper', __FILE__)
class ApiTest::MembershipsTest < ActionController::IntegrationTest
fixtures :projects, :users, :roles, :members, :member_roles
def setup
Setting.rest_api_enabled = '1'
end
context "/projects/:project_id/memberships" do
context "GET" do
context "xml" do
should "return memberships" do
get '/projects/1/memberships.xml', {}, credentials('jsmith')
assert_response :success
assert_equal 'application/xml', @response.content_type
assert_tag :tag => 'memberships',
:attributes => {:type => 'array'},
:child => {
:tag => 'membership',
:child => {
:tag => 'id',
:content => '2',
:sibling => {
:tag => 'user',
:attributes => {:id => '3', :name => 'Dave Lopper'},
:sibling => {
:tag => 'roles',
:child => {
:tag => 'role',
:attributes => {:id => '2', :name => 'Developer'}
}
}
}
}
}
end
end
context "json" do
should "return memberships" do
get '/projects/1/memberships.json', {}, credentials('jsmith')
assert_response :success
assert_equal 'application/json', @response.content_type
json = ActiveSupport::JSON.decode(response.body)
assert_equal({
"memberships" =>
[{"id"=>1,
"project" => {"name"=>"eCookbook", "id"=>1},
"roles" => [{"name"=>"Manager", "id"=>1}],
"user" => {"name"=>"John Smith", "id"=>2}},
{"id"=>2,
"project" => {"name"=>"eCookbook", "id"=>1},
"roles" => [{"name"=>"Developer", "id"=>2}],
"user" => {"name"=>"Dave Lopper", "id"=>3}}],
"limit" => 25,
"total_count" => 2,
"offset" => 0},
json)
end
end
end
context "POST" do
context "xml" do
should "create membership" do
assert_difference 'Member.count' do
post '/projects/1/memberships.xml', {:membership => {:user_id => 7, :role_ids => [2,3]}}, credentials('jsmith')
assert_response :created
end
end
should "return errors on failure" do
assert_no_difference 'Member.count' do
post '/projects/1/memberships.xml', {:membership => {:role_ids => [2,3]}}, credentials('jsmith')
assert_response :unprocessable_entity
assert_equal 'application/xml', @response.content_type
assert_tag 'errors', :child => {:tag => 'error', :content => "Principal can't be blank"}
end
end
end
end
end
context "/memberships/:id" do
context "GET" do
context "xml" do
should "return the membership" do
get '/memberships/2.xml', {}, credentials('jsmith')
assert_response :success
assert_equal 'application/xml', @response.content_type
assert_tag :tag => 'membership',
:child => {
:tag => 'id',
:content => '2',
:sibling => {
:tag => 'user',
:attributes => {:id => '3', :name => 'Dave Lopper'},
:sibling => {
:tag => 'roles',
:child => {
:tag => 'role',
:attributes => {:id => '2', :name => 'Developer'}
}
}
}
}
end
end
context "json" do
should "return the membership" do
get '/memberships/2.json', {}, credentials('jsmith')
assert_response :success
assert_equal 'application/json', @response.content_type
json = ActiveSupport::JSON.decode(response.body)
assert_equal(
{"membership" => {
"id" => 2,
"project" => {"name"=>"eCookbook", "id"=>1},
"roles" => [{"name"=>"Developer", "id"=>2}],
"user" => {"name"=>"Dave Lopper", "id"=>3}}
},
json)
end
end
end
context "PUT" do
context "xml" do
should "update membership" do
assert_not_equal [1,2], Member.find(2).role_ids.sort
assert_no_difference 'Member.count' do
Jean-Philippe Lang
Typo...
 r8683 put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [1,2]}}, credentials('jsmith')
Jean-Philippe Lang
REST API for project memberships (#7420)....
 r8678
assert_response :ok
Jean-Philippe Lang
Fixed that 200 API responses have a body containing one space (#11388)....
 r9792 assert_equal '', @response.body
Jean-Philippe Lang
REST API for project memberships (#7420)....
 r8678 end
member = Member.find(2)
assert_equal [1,2], member.role_ids.sort
end
Jean-Philippe Lang
Additional test for memberships API....
 r9313
should "return errors on failure" do
put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [99]}}, credentials('jsmith')
assert_response :unprocessable_entity
assert_equal 'application/xml', @response.content_type
Jean-Philippe Lang
Merged rails-3.2 branch....
 r9346 assert_tag 'errors', :child => {:tag => 'error', :content => /member_roles is invalid/}
Jean-Philippe Lang
Additional test for memberships API....
 r9313 end
Jean-Philippe Lang
REST API for project memberships (#7420)....
 r8678 end
end
context "DELETE" do
context "xml" do
should "destroy membership" do
assert_difference 'Member.count', -1 do
delete '/memberships/2.xml', {}, credentials('jsmith')
assert_response :ok
Jean-Philippe Lang
Fixed that 200 API responses have a body containing one space (#11388)....
 r9792 assert_equal '', @response.body
Jean-Philippe Lang
REST API for project memberships (#7420)....
 r8678 end
assert_nil Member.find_by_id(2)
end
should "respond with 422 on failure" do
assert_no_difference 'Member.count' do
# A membership with an inherited role can't be deleted
Member.find(2).member_roles.first.update_attribute :inherited_from, 99
delete '/memberships/2.xml', {}, credentials('jsmith')
assert_response :unprocessable_entity
end
end
end
end
end
end